This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Removing RuntimeFrameworkVersion and the workaround added in PR #1702. #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test this please |
shiftylogic
approved these changes
Sep 12, 2017
|
Since #1736 is still blocked on new cli, I will merge this change in so we can get the latest changes from System.Memory/etc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest packages, we can remove the previously added workaround in PR #1702.
This will resolve the errors we see here (#1703) like:
error CS0012: The type 'ValueType' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. [D:\j\workspace\windows_nt_de---4b678204\tests\System.Binary.Tests\System.Binary.Tests.csproj]
https://ci.dot.net/job/dotnet_corefxlab/job/master/job/windows_nt_debug_prtest/649/
However, the new packages reveal a new issue that needs to be resolved: https://github.com/dotnet/corefx/issues/23656
Do not merge until the above issue has been resolved.
cc @shiftylogic, @KrzysztofCwalina