Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grammar rule #2238

Merged
merged 1 commit into from Feb 19, 2019
Merged

fix grammar rule #2238

merged 1 commit into from Feb 19, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 16, 2019

The current syntax does not require a multiline comment to end with '*/'.
So,

delimited_comment
    : '/*' delimited_comment_section* asterisk* '/'
    ;

should be:

delimited_comment
    : '/*' delimited_comment_section* asterisk+ '/'
    ;

delimited_comment
    : '/*' delimited_comment_section* asterisk* '/'
    ;
should be
delimited_comment
    : '/*' delimited_comment_section* asterisk+ '/'
    ;
Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Comment retracted]

@gafter gafter merged commit a93a0df into dotnet:master Feb 19, 2019
@ghost ghost deleted the patch-3 branch February 19, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant