Standardize list pattern lowering on Index constructor.
#5484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
approved these changes
Nov 30, 2021
jcouv
approved these changes
Nov 30, 2021
AlekseyTs
added a commit
to AlekseyTs/roslyn
that referenced
this pull request
Dec 1, 2021
Fixes dotnet#57825. Relevant spec adjustment dotnet/csharplang#5484.
alrz
reviewed
Dec 1, 2021
Comment on lines
-84
to
+86
| && expr[0] is 1 | ||
| && expr[1] is 2 | ||
| && expr[2] is 3 | ||
| && expr[new Index(0, fromEnd: false)] is 1 | ||
| && expr[new Index(1, fromEnd: false)] is 2 | ||
| && expr[new Index(2, fromEnd: false)] is 3 |
There was a problem hiding this comment.
(if compatible via implicit
Indexsupport)
This section presents the lowering with implicit indexer (using an int arg)
There was a problem hiding this comment.
This section presents the lowering with implicit indexer (using an int arg)
Removed the reference to the implicit indexer there.
AlekseyTs
commented
Dec 2, 2021
AlekseyTs
added a commit
to dotnet/roslyn
that referenced
this pull request
Dec 4, 2021
Fixes #57825. Relevant spec adjustment dotnet/csharplang#5484.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/roslyn#57825