-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust dynamic binding rules for a situation of a single applicable candidate. #8027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andidate. Meant to mitigate breaking changes like dotnet/roslyn#72750.
AlekseyTs
changed the title
Adjust dynamic binding rules for a situation of a single applicable c…
Adjust dynamic binding rules for a situation of a single applicable candidate.
Apr 1, 2024
jaredpar
approved these changes
Apr 1, 2024
jjonescz
reviewed
Apr 5, 2024
AlekseyTs
added a commit
to AlekseyTs/roslyn
that referenced
this pull request
Apr 5, 2024
…have `dynamic` result if their dynamic binding succeeded in C# 12 Fixes dotnet#72750. Corresponding spec update - dotnet/csharplang#8027
jaredpar
reviewed
Apr 5, 2024
jaredpar
approved these changes
Apr 6, 2024
jjonescz
reviewed
Apr 8, 2024
Co-authored-by: Jan Jones <[email protected]>
AlekseyTs
added a commit
to dotnet/roslyn
that referenced
this pull request
Apr 11, 2024
…c` arguments (#72964) Fixes #72750. For C# 12 language version: behavior of the compiler in regards to deciding between whether binding should be static or dynamic is the same as behavior of C# 12 compiler. As a result, for affected scenarios, what used to have `dynamic` type in C# 12 compiler will have `dynamic` type when C# 12 language version is targeted. For newer language versions: invocations statically bound in presence of dynamic arguments should have dynamic result if their dynamic binding succeeded in C# 12. Corresponding spec update - dotnet/csharplang#8027 at commit 8. Related to #33011, #72906, #72912, #72913, #72914, #72916, #72931.
AlekseyTs
added a commit
to AlekseyTs/roslyn
that referenced
this pull request
Apr 16, 2024
…c` arguments (dotnet#72964) Fixes dotnet#72750. For C# 12 language version: behavior of the compiler in regards to deciding between whether binding should be static or dynamic is the same as behavior of C# 12 compiler. As a result, for affected scenarios, what used to have `dynamic` type in C# 12 compiler will have `dynamic` type when C# 12 language version is targeted. For newer language versions: invocations statically bound in presence of dynamic arguments should have dynamic result if their dynamic binding succeeded in C# 12. Corresponding spec update - dotnet/csharplang#8027 at commit 8. Related to dotnet#33011, dotnet#72906, dotnet#72912, dotnet#72913, dotnet#72914, dotnet#72916, dotnet#72931.
AlekseyTs
added a commit
to dotnet/roslyn
that referenced
this pull request
Apr 17, 2024
Restore dynamic as result type of some operations involving dynamic arguments (#72964) Fixes #72750. For C# 12 language version: behavior of the compiler in regards to deciding between whether binding should be static or dynamic is the same as behavior of C# 12 compiler. As a result, for affected scenarios, what used to have dynamic type in C# 12 compiler will have dynamic type when C# 12 language version is targeted. For newer language versions: invocations statically bound in presence of dynamic arguments should have dynamic result if their dynamic binding succeeded in C# 12. Corresponding spec update - dotnet/csharplang#8027 at commit 8. Related to #33011, #72906, #72912, #72913, #72914, #72916, #72931.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to mitigate breaking changes like dotnet/roslyn#72750.