Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Activity API usability and OpenTelemetry integration (Part 2) #134

Merged
merged 14 commits into from
Jul 16, 2020
Merged

Improve Activity API usability and OpenTelemetry integration (Part 2) #134

merged 14 commits into from
Jul 16, 2020

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jun 11, 2020

No description provided.

@tarekgh
Copy link
Member Author

tarekgh commented Jun 11, 2020 •
edited
Loading

https://github.com/dotnet/designs/blob/master/accepted/2020/diagnostics/activity-improvements.md
dotnet/runtime#31373

reyang
reyang approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall approach looks good to me. I'm a bit on the fence with the naming but I don't feel that I have a strong enough opinion to block this PR.

pjanotti
pjanotti approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

noahfalk
noahfalk reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tarekgh! Sorry I forgot about this one. I added comments/questions inline and I'll try to respond more promptly to any follow up discussion on it.

@tarekgh tarekgh mentioned this pull request Jun 26, 2020
Closed
@tarekgh
Copy link
Member Author

tarekgh commented Jun 26, 2020

I have updated the doc reflecting the final edition. thanks all for your feedback!

@tarekgh tarekgh mentioned this pull request Jul 10, 2020
Merged
@tarekgh tarekgh merged commit 00fb2c1 into dotnet:master Jul 16, 2020
@tarekgh tarekgh deleted the activity-improvements-2 branch July 16, 2020 17:28
@tarekgh tarekgh mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahfalk noahfalk noahfalk left review comments

@reyang reyang reyang approved these changes

@cijothomas cijothomas cijothomas approved these changes

@pjanotti pjanotti pjanotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tarekgh @cijothomas @pjanotti @noahfalk @reyang