Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch to fix dotnet-counters rendering issues #2971

Merged

Conversation

mikelle-rogers
Copy link
Member

Want to talk with Windows folks about this behavior. For now, here is a patch that fixes #2970 and possibly #2934

@mikelle-rogers mikelle-rogers added this to the .NET 7.0 milestone Mar 31, 2022
@mikelle-rogers mikelle-rogers requested a review from a team as a code owner March 31, 2022 21:16
@mikelle-rogers mikelle-rogers self-assigned this Mar 31, 2022
@mikelle-rogers mikelle-rogers requested a review from josalem April 1, 2022 21:56
Copy link
Contributor

@josalem josalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's also open an issue to track communicating with the windows console folks to figure out why it declares ANSI support but isn't handling control sequences correctly.

@hoyosjs hoyosjs merged commit e0c184f into dotnet:main Apr 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet-counters monitor on Windows powershell and cmd prints various incorrectly formatted outputs
3 participants