Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: calculate internal cross-reference URL without xrefmap #8588

Merged
merged 4 commits into from
Apr 10, 2023
Merged

feat: calculate internal cross-reference URL without xrefmap #8588

merged 4 commits into from
Apr 10, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Apr 3, 2023

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Apr 3, 2023
@yufeih yufeih force-pushed the symbolurl-docfx branch from 3eb4db9 to 47f249d Compare April 3, 2023 09:27
@codecov
Copy link

codecov bot commented Apr 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 93.93% and no project coverage change.

Comparison is base (dcc61b8) 74.58% compared to head (a718680) 74.59%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8588   +/-   ##
=======================================
  Coverage   74.58%   74.59%           
=======================================
  Files         629      629           
  Lines       22853    22875   +22     
=======================================
+ Hits        17046    17063   +17     
- Misses       5807     5812    +5
Impacted Files Coverage Δ
...rc/Microsoft.DocAsCode.Dotnet/SymbolUrlResolver.cs 90.00% <89.47%> (-10.00%) ⬇️
...de.Dotnet/ExtractMetadata/ExtractMetadataWorker.cs 79.12% <100.00%> (+0.23%) ⬆️
src/Microsoft.DocAsCode.Dotnet/SymbolFormatter.cs 100.00% <100.00%> (ø)
src/Microsoft.DocAsCode.Dotnet/SymbolHelper.cs 96.96% <100.00%> (ø)
...ft.DocAsCode.Dotnet/Visitors/YamlModelGenerator.cs 97.91% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih closed this Apr 3, 2023
@yufeih yufeih reopened this Apr 3, 2023
@yufeih yufeih marked this pull request as ready for review April 3, 2023 09:45
@yufeih yufeih closed this Apr 9, 2023
@yufeih yufeih reopened this Apr 9, 2023
@yufeih yufeih merged commit d002182 into main Apr 10, 2023
@yufeih yufeih deleted the symbolurl-docfx branch April 10, 2023 02:49
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2023
Closed
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
@yufeih @p-kostov
feat: calculate internal cross-reference URL without xrefmap (dotnet#…
3e70513 
…8588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yufeih