Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post merge feedback #1372

Merged
merged 12 commits into from
Jul 17, 2024
Merged

Post merge feedback #1372

merged 12 commits into from
Jul 17, 2024

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jul 17, 2024 •
edited by github-actions bot
Loading

@IEvangelist IEvangelist requested a review from eerhardt July 17, 2024 14:33
@IEvangelist IEvangelist requested a review from BillWagner July 17, 2024 14:57
BillWagner
BillWagner approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@IEvangelist IEvangelist marked this pull request as draft July 17, 2024 16:30
@IEvangelist IEvangelist marked this pull request as ready for review July 17, 2024 17:54
eerhardt
eerhardt approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IEvangelist IEvangelist merged commit 8dec12e into dotnet:main Jul 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include credentials in connection string
3 participants
@IEvangelist @BillWagner @eerhardt