-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relate coding conventions to diagnostics and editorconfig settings #33341
Comments
While doing this work, note that this article has a recommendation that local functions should be We've generally preferred PascalCasing for methods because we chose PascalCase for all methods, regardless of access. We think of local functions as functions first. The fact they their scope is local is less important for the name. |
This has already been addressed in #33341 |
- dotnet#33341 already addressed in dotnet#36428. - Fixes dotnet#37294: Add text that the shortened format is valid only when the runtime type matches the variable type. - Fixes dotnet#37295: Don't use `ID` in the sample. - Fixes dotnet#37296: Fix nullable warnings. Other issue comments are incorrect. - Fixes dotnet#41748: Change the sample so the constructor is relevant.
- dotnet#33341 already addressed in dotnet#36428. - Fixes dotnet#37294: Add text that the shortened format is valid only when the runtime type matches the variable type. - Fixes dotnet#37295: Don't use `ID` in the sample. - Fixes dotnet#37296: Fix nullable warnings. Other issue comments are incorrect. - Fixes dotnet#41748: Change the sample so the constructor is relevant.
- dotnet#33341 already addressed in dotnet#36428. - Fixes dotnet#37294: Add text that the shortened format is valid only when the runtime type matches the variable type. - Fixes dotnet#37295: Don't use `ID` in the sample. - Fixes dotnet#37296: Fix nullable warnings. Other issue comments are incorrect. - Fixes dotnet#41748: Change the sample so the constructor is relevant.
- dotnet#33341 already addressed in dotnet#36428. - Fixes dotnet#37294: Add text that the shortened format is valid only when the runtime type matches the variable type. - Fixes dotnet#37295: Don't use `ID` in the sample. - Fixes dotnet#37296: Fix nullable warnings. Other issue comments are incorrect. - Fixes dotnet#41748: Change the sample so the constructor is relevant. - Fixes dotnet#42858: Add an explanation on declaring variables in top level statements.
- dotnet#33341 already addressed in dotnet#36428. - Fixes dotnet#37294: Add text that the shortened format is valid only when the runtime type matches the variable type. - Fixes dotnet#37295: Don't use `ID` in the sample. - Fixes dotnet#37296: Fix nullable warnings. Other issue comments are incorrect. - Fixes dotnet#41748: Change the sample so the constructor is relevant. - Fixes dotnet#42858: Add an explanation on declaring variables in top level statements.
* Fix small open issues. - #33341 already addressed in #36428. - Fixes #37294: Add text that the shortened format is valid only when the runtime type matches the variable type. - Fixes #37295: Don't use `ID` in the sample. - Fixes #37296: Fix nullable warnings. Other issue comments are incorrect. - Fixes #41748: Change the sample so the constructor is relevant. - Fixes #42858: Add an explanation on declaring variables in top level statements. * Remaining open issues - Fixes #43838: Add notes for collection expressions and using primary constructors. Include naming recommendations. - Fixes #43839 Update the overview of constructors to include information on primary constructors. * Code review for style Fix any style issues with the current code. * Final edit pass I also caught a couple sample bits that I'd neglected in the previous commit. * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> --------- Co-authored-by: Genevieve Warren <[email protected]>
This article contains a set of guidelines that have different levels of adoption across the C# community. Some are almost universal (interfaces start with a capital
I
). Some are more common, but not universal (starting fields with_
). Some have fallen out of favor in recent times.This page needs to be updated to reflect current styles.
Furthermore, we should categorize coding conventions to the kinds of diagnostics available:
In addition, we should reference the preferred style used by the runtime. That's a common style seen by .NET developers browsing our source, and it's generally consistent with what we use in docs.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
Associated WorkItem - 58354
The text was updated successfully, but these errors were encountered: