-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create native interop section #34132
Conversation
The previous "index" article was an old landing page that had only an introductory paragraph and then links to the additional articles in the section. Consolidate the opening paragraph with the overview.
Snippets haven't moved until I get clarity on sample story.
Split this article in 2 while moving it. This will make it easier to find for VB developers looking for the VB version. And, the C# version reads more cleanly.
Move the PInvoke sample to the new folder.
Once again, this is a larger PR in terms of the number of files. However, not much changed in the files or the code samples. I did run Acrolinx and fix many of those style issues. Beyond that, this moved files, updated links, and created the new section. One area that should be reviewed: Two walkthroughs dated from the time when C# and VB were "co-evolving". There was a single article that mixed both C# and VB samples for dynamic programming. In both cases, I split that article in two, creating a VB and a C# version of each article. Links are here:
I didn't run Acrolinx on the VB samples. |
The one snippets 5000 error in this PR is odd to me. It's the Office Interop VSTO project. Thecontainer doesn't have that workload, so it's an expected failure. I've added that to the expected errors page, but it's not working correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Approving to unblock.
- One minor suggestion with headers
- One fix for snippets build.
docs/csharp/advanced-topics/interop/walkthrough-office-programming.md
Outdated
Show resolved
Hide resolved
docs/csharp/advanced-topics/interop/snippets/OfficeWalkthrough/snippets5000.json
Outdated
Show resolved
Hide resolved
closing and reopening for a fresh CI build |
556a02b
to
03df447
Compare
Contributes to #33878
Move the articles on interop into the advanced topics section.