Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create native interop section #34132

Merged
merged 34 commits into from
Feb 24, 2023
Merged

Conversation

BillWagner
Copy link
Member

Contributes to #33878

Move the articles on interop into the advanced topics section.

The previous "index" article was an old landing page that had only an introductory paragraph and then links to the additional articles in the section. Consolidate the opening paragraph with the overview.
Snippets haven't moved until I get clarity on sample story.
Split this article in 2 while moving it. This will make it easier to find for VB developers looking for the VB version. And, the C# version reads more cleanly.
@BillWagner BillWagner changed the title Create advanced section Create native interop section Feb 16, 2023
@BillWagner BillWagner marked this pull request as ready for review February 17, 2023 21:07
@BillWagner
Copy link
Member Author

Once again, this is a larger PR in terms of the number of files. However, not much changed in the files or the code samples. I did run Acrolinx and fix many of those style issues.

Beyond that, this moved files, updated links, and created the new section.

One area that should be reviewed:

Two walkthroughs dated from the time when C# and VB were "co-evolving". There was a single article that mixed both C# and VB samples for dynamic programming. In both cases, I split that article in two, creating a VB and a C# version of each article. Links are here:

I didn't run Acrolinx on the VB samples.

@BillWagner
Copy link
Member Author

@adegeo

The one snippets 5000 error in this PR is odd to me. It's the Office Interop VSTO project. Thecontainer doesn't have that workload, so it's an expected failure. I've added that to the expected errors page, but it's not working correctly.

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approving to unblock.

  • One minor suggestion with headers
  • One fix for snippets build.

@BillWagner
Copy link
Member Author

closing and reopening for a fresh CI build

@BillWagner BillWagner force-pushed the create-advanced-section branch from 556a02b to 03df447 Compare February 24, 2023 17:44
@BillWagner BillWagner disabled auto-merge February 24, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants