Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diagnostics] Update dotnet trace docs #37749

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Oct 26, 2023

Summary

Updates dotnet-trace collect's --output default value.
Add dotnet-trace collect's --resume-runtime option from dotnet/diagnostics#2343.
Add dotnet-trace collect's --stopping-event-* options from dotnet/diagnostics#4363.


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/dotnet-trace.md dotnet-trace performance analysis utility

@mdh1418 mdh1418 requested review from tommcdon and a team as code owners October 26, 2023 20:26
@dotnet-bot dotnet-bot added this to the October 2023 milestone Oct 26, 2023
@mdh1418 mdh1418 force-pushed the update_dotnet_trace_stopping_event branch from 90efc85 to ac92b5c Compare October 26, 2023 20:37
@mikelle-rogers mikelle-rogers self-requested a review October 27, 2023 17:20
Copy link
Member

@mikelle-rogers mikelle-rogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdh1418 mdh1418 merged commit e0576eb into dotnet:main Oct 27, 2023
@mdh1418 mdh1418 deleted the update_dotnet_trace_stopping_event branch October 27, 2023 17:43
@mdh1418
Copy link
Member Author

mdh1418 commented Oct 27, 2023

Oops, it doesn't seem like squash + merge is the default... would this be a problem?

@gewarren
Copy link
Contributor

Oops, it doesn't seem like squash + merge is the default... would this be a problem?

It should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants