Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes GitHub issue #30860 - Confusing use of "default" for langversion #37802

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Fixes GitHub issue #30860 - Confusing use of "default" for langversion #37802

merged 5 commits into from
Oct 31, 2023

Conversation

v-thepet
Copy link
Contributor

@v-thepet v-thepet commented Oct 30, 2023 •
edited by github-actions bot
Loading

@v-thepet v-thepet requested a review from BillWagner as a code owner October 30, 2023 21:54
@dotnet-bot dotnet-bot added this to the October 2023 milestone Oct 30, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Oct 30, 2023
@v-thepet v-thepet closed this Oct 30, 2023
@v-thepet v-thepet reopened this Oct 30, 2023
@v-thepet v-thepet closed this Oct 30, 2023
@v-thepet
Copy link
Contributor Author

Preview links aren't working.

@v-thepet v-thepet reopened this Oct 30, 2023
BillWagner
BillWagner approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, with one small nit.

docs/csharp/language-reference/compiler-options/language.md Outdated Show resolved Hide resolved
@BillWagner BillWagner enabled auto-merge (squash) October 31, 2023 16:13
@BillWagner BillWagner merged commit 178264a into dotnet:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc lang-reference/subsvc
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

Confusing use of "default" for langversion
3 participants
@v-thepet @BillWagner @dotnet-bot