Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note per issue 26068. #37805

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

TimShererWithAquent
Copy link
Contributor

@TimShererWithAquent TimShererWithAquent commented Oct 30, 2023

Summary

Added explanation about term "destructor".

There were two previous abandoned fixes for this issue. If my fix is not OK, I recommend that we close the issue as won't fix and include a note in ALL CAPS that the issue should NOT be reopened.

Fixes #26068


Internal previews

📄 File 🔗 Preview link
docs/csharp/misc/cs0250.md Compiler Error CS0250

@dotnet-bot dotnet-bot added this to the October 2023 milestone Oct 30, 2023
@ghost ghost added community-contribution Indicates PR is created by someone from the .NET community. okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. labels Oct 30, 2023
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @TimShererWithAquent

I'll :shipit: now.

@BillWagner BillWagner merged commit a52b610 into dotnet:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc errors-warnings/subsvc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler Error CS0250 – destructor is outdated term
3 participants