Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build suggestions - October #37816

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix build suggestions - October #37816

merged 2 commits into from
Oct 31, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 31, 2023 •
edited by github-actions bot
Loading

@dotnet-bot dotnet-bot added this to the October 2023 milestone Oct 31, 2023
tdykstra
tdykstra approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren gewarren merged commit 48f9185 into dotnet:main Oct 31, 2023
@gewarren gewarren deleted the warnings1031 branch October 31, 2023 18:37
@gewarren
Copy link
Contributor Author

Thanks @tdykstra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

@adegeo adegeo Awaiting requested review from adegeo adegeo is a code owner

@tommcdon tommcdon Awaiting requested review from tommcdon tommcdon is a code owner

@nishanil nishanil Awaiting requested review from nishanil nishanil is a code owner

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
cloud-native/subsvc dotnet-architecture/svc dotnet-azure/svc dotnet-fundamentals/svc
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@gewarren @tdykstra @dotnet-bot