Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AssemblyBuilder.md with persistable AssemblyBuilder info #39491

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Update AssemblyBuilder.md with persistable AssemblyBuilder info #39491

merged 5 commits into from
Feb 14, 2024

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Feb 13, 2024 •
edited by github-actions bot
Loading

Summary

Update the reflection emit conceptual doc with the new persistable AssemblyBuilder usage

Related to dotnet/runtime#15704

Internal previews

📄 File 🔗 Preview link
docs/core/porting/net-framework-tech-unavailable.md .NET Framework technologies unavailable on .NET
docs/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder.md System.Reflection.Emit.AssemblyBuilder class

@buyaa-n buyaa-n requested a review from a team as a code owner February 13, 2024 02:24
@dotnet-bot dotnet-bot added this to the February 2024 milestone Feb 13, 2024
@buyaa-n buyaa-n force-pushed the new_ab branch 2 times, most recently from 2ea535b to c3c73b1 Compare February 13, 2024 02:51
gewarren
gewarren requested changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite through reviewing it yet.

@buyaa-n @gewarren
Apply suggestions from code review
0e5dbe1 
Co-authored-by: Genevieve Warren <[email protected]>
@buyaa-n @gewarren
Apply suggestions from code review
0ebe4f2 
Co-authored-by: Genevieve Warren <[email protected]>
@buyaa-n @gewarren
Apply suggestions from code review
56d54ac 
Co-authored-by: Genevieve Warren <[email protected]>
@buyaa-n
Copy link
Contributor Author

buyaa-n commented Feb 14, 2024

Thank you for the review @gewarren

@buyaa-n buyaa-n merged commit 41f9dda into dotnet:main Feb 14, 2024
8 checks passed
@buyaa-n buyaa-n deleted the new_ab branch February 14, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley

@steveharter steveharter Awaiting requested review from steveharter

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
February 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@buyaa-n @gewarren @dotnet-bot