Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Introduction of Wildcard Pattern in F# Pattern Matching Documentation #44154

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

shethaadit
Copy link
Contributor

@shethaadit shethaadit commented Jan 5, 2025

Summary

This PR updates the F# Pattern Matching documentation to clarify the introduction of the _ (Wildcard Pattern). The original text implied its use in the preceding example, but it is actually introduced in the following example. The updated wording ensures accuracy while retaining the original intent and style.

Changes include:

Adjusted text to specify that the _ pattern is introduced in the following example.
Retained original wordings where not necessary to change.
This improves the clarity and accuracy of the documentation for users.

Fixes #37053


Internal previews

📄 File 🔗 Preview link
docs/fsharp/tour.md Tour of F#

@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 5, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fsharp/svc community-contribution Indicates PR is created by someone from the .NET community. labels Jan 5, 2025
docs/fsharp/tour.md Outdated Show resolved Hide resolved
Co-authored-by: Tomas Grosup <[email protected]>
@shethaadit
Copy link
Contributor Author

Hu @T-Gro , I have applied your suggestion.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @shethaadit

This LGTM, and I'll :shipit: now.

@BillWagner BillWagner enabled auto-merge (squash) January 6, 2025 15:12
@BillWagner BillWagner merged commit 6ed67fe into dotnet:main Jan 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fsharp/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected first mention of Wildcard Pattern
3 participants