Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port System.IO new docs (second pass) #10210

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Aug 6, 2024

Some APIs were missed in the previous PR.

Contributes to dotnet/runtime#105979

@carlossanlop carlossanlop requested review from gewarren and a team August 6, 2024 22:33
@carlossanlop carlossanlop self-assigned this Aug 6, 2024
@carlossanlop carlossanlop requested a review from a team as a code owner August 6, 2024 22:33
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io

This comment was marked as outdated.

xml/System.IO/File.xml Outdated Show resolved Hide resolved
xml/System.IO/File.xml Outdated Show resolved Hide resolved
xml/System.IO/File.xml Outdated Show resolved Hide resolved
xml/System.IO/File.xml Outdated Show resolved Hide resolved
@jozkee
Copy link
Member

jozkee commented Aug 7, 2024

@adegeo @dotnet/docs for overloads using the new params ReadOnlySpan<T> language feature, they should render as params, not as scoped I believe:
image

cc @stephentoub

xml/System.IO/TextWriter.xml Outdated Show resolved Hide resolved
@carlossanlop carlossanlop requested review from jozkee and adegeo August 7, 2024 19:46
@carlossanlop
Copy link
Member Author

@adegeo @dotnet/docs for overloads using the new params ReadOnlySpan<T> language feature, they should render as params, not as scoped I believe:

I opened a bug for the Docs Dev Team: https://dev.azure.com/ceapex/Engineering/_workitems/edit/989732

cc @gewarren

This comment was marked as outdated.

@carlossanlop
Copy link
Member Author

The NFloat failure is unrelated to this PR, I'm fixing it here: #10211 (comment)

xml/System.IO/File.xml Outdated Show resolved Hide resolved
xml/System.IO/File.xml Outdated Show resolved Hide resolved
xml/System.IO/File.xml Outdated Show resolved Hide resolved
xml/System.IO/File.xml Outdated Show resolved Hide resolved
xml/System.IO/File.xml Outdated Show resolved Hide resolved
xml/System.IO/File.xml Outdated Show resolved Hide resolved
xml/System.IO/File.xml Outdated Show resolved Hide resolved
xml/System.IO/File.xml Outdated Show resolved Hide resolved
@carlossanlop carlossanlop requested a review from jozkee August 9, 2024 19:50

This comment was marked as outdated.

xml/System.IO/File.xml Outdated Show resolved Hide resolved
@carlossanlop carlossanlop enabled auto-merge (squash) August 12, 2024 18:49
Copy link

Learn Build status updates of commit d6aa03a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/File.xml ✅Succeeded View
xml/System.IO/Path.xml ✅Succeeded View
xml/System.IO/StreamWriter.xml ✅Succeeded View
xml/System.IO/TextWriter.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@carlossanlop carlossanlop merged commit 60b5435 into dotnet:main Aug 12, 2024
3 checks passed
@carlossanlop carlossanlop deleted the PortSystemIO branch August 13, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants