-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify memory load #6868
Clarify memory load #6868
Conversation
Docs Build status updates of commit dbefef0: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
xml/System/GCMemoryInfo.xml
Outdated
@@ -75,9 +75,9 @@ A GC is identified by its <xref:System.GCMemoryInfo.Index>, which starts from 1 | |||
<ReturnType>System.Boolean</ReturnType> | |||
</ReturnValue> | |||
<Docs> | |||
<summary>Gets a value that indicates if this is a concurrent GC (BGC) or not.</summary> | |||
<summary>Gets a value that indicates if this is a background or concurrent GC or not.</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
background GCs are concurrent. so I would keep the original text; or if you want to make it more explicit you could say
Gets a value that indicates if this is a background (which is concurrent) or not.
xml/System/GCMemoryInfo.xml
Outdated
<remarks>To be added.</remarks> | ||
<summary>Gets the physical memory load when the last garbage collection occurred.</summary> | ||
<value>The physical memory load, in bytes, when the last garbage collection occurred.</value> | ||
<remarks>If you don't touch the pages of an object, the memory load doesn't change significantly.</remarks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably say this -
"Data is only brought into physical memory on first touch so if you allocated a big object but doesn't actually use it, most of its memory will not be in physical memory so you could see the memory load change much."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much!
Docs Build status updates of commit 0af6cab: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
See dotnet/runtime#55126 (comment).