Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify memory load #6868

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Clarify memory load #6868

merged 2 commits into from
Jul 7, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jul 7, 2021

@gewarren gewarren requested a review from Maoni0 July 7, 2021 21:15
@gewarren gewarren requested a review from a team as a code owner July 7, 2021 21:15
@opbld34
Copy link

opbld34 commented Jul 7, 2021

Docs Build status updates of commit dbefef0:

✅ Validation status: passed

File Status Preview URL Details
xml/System/GCMemoryInfo.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@@ -75,9 +75,9 @@ A GC is identified by its <xref:System.GCMemoryInfo.Index>, which starts from 1
<ReturnType>System.Boolean</ReturnType>
</ReturnValue>
<Docs>
<summary>Gets a value that indicates if this is a concurrent GC (BGC) or not.</summary>
<summary>Gets a value that indicates if this is a background or concurrent GC or not.</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

background GCs are concurrent. so I would keep the original text; or if you want to make it more explicit you could say

Gets a value that indicates if this is a background (which is concurrent) or not.

<remarks>To be added.</remarks>
<summary>Gets the physical memory load when the last garbage collection occurred.</summary>
<value>The physical memory load, in bytes, when the last garbage collection occurred.</value>
<remarks>If you don't touch the pages of an object, the memory load doesn't change significantly.</remarks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably say this -

"Data is only brought into physical memory on first touch so if you allocated a big object but doesn't actually use it, most of its memory will not be in physical memory so you could see the memory load change much."

Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much!

@opbld34
Copy link

opbld34 commented Jul 7, 2021

Docs Build status updates of commit 0af6cab:

✅ Validation status: passed

File Status Preview URL Details
xml/System/GCMemoryInfo.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit ef361aa into main Jul 7, 2021
@gewarren gewarren deleted the gewarren-patch-1 branch July 7, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants