Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nightly] Update dependencies from dotnet/installer #4623

Conversation

dotnet-docker-bot
Copy link
Contributor

No description provided.

@dotnet-docker-bot dotnet-docker-bot requested review from a team and jander-msft as code owners May 17, 2023 13:05
@dotnet-docker-bot dotnet-docker-bot force-pushed the nightly-UpdateDependencies-nightly-From-dotnet-installer branch from f7f1cbf to d19560c Compare May 17, 2023 13:05
@mthalman
Copy link
Member

@lbussell - Looks like there is a genuine product issue here based on the test results. Looks like the app could be crashing? Needs further investigation.

@lbussell
Copy link
Contributor

@marcpopMSFT or @dsplaisted does this sound like a product issue with preview 5? We have a test failure where we are trying to run a self-contained app and it asks for .NET to be installed:

root@f9487500e959:/app# ./app
You must install .NET to run this application.

App: /app/app
Architecture: x64
App host version: 8.0.0-preview.5.23260.3
.NET location: Not found

Learn more:
https://aka.ms/dotnet/app-launch-failed

Download the .NET runtime:
https://aka.ms/dotnet-core-applaunch?missing_runtime=true&arch=x64&rid=debian.12-x64&apphost_version=8.0.0-preview.5.23260.3

The relevant build/publish steps in the Dockerfile are here:

FROM build as publish_self_contained
ARG rid
RUN dotnet publish -r $rid -c Release -o out
FROM $runtime_deps_image AS self_contained_app
ARG port
EXPOSE $port
WORKDIR /app
COPY --from=publish_self_contained /source/app/out ./
ENTRYPOINT ["./app"]

@mthalman
Copy link
Member

It looks like this is relevant: dotnet/sdk#32549.

The Dockerfile should be updated to explicitly provide the --self-contained option.

@dsplaisted
Copy link
Member

This is a breaking change as described here: dotnet/docs#33726

Basically, -r doesn't imply self-contained anymore. You need to also specify --self-contained.

FYI @richlander @nagilson

@lbussell
Copy link
Contributor

lbussell commented May 18, 2023

Thanks for the info. I verified locally and specifying --self-contained seems to work.

@lbussell lbussell merged commit be06137 into dotnet:nightly May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants