Skip to content

Commit

Permalink
Query: Remove redundant override of TranslateSubquery
Browse files Browse the repository at this point in the history
Added override to do custom task for GroupBy which ended up getting removed in final implementation but method was left behind

Part of #24743
  • Loading branch information
smitpatel authored Aug 21, 2021
1 parent 23b33a1 commit 3533470
Showing 1 changed file with 0 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -158,21 +158,6 @@ when queryRootExpression.EntityType.GetSqlQueryMappings().FirstOrDefault(m => m.
}
}

/// <inheritdoc />
public override ShapedQueryExpression? TranslateSubquery(Expression expression)
{
Check.NotNull(expression, nameof(expression));

var subqueryVisitor = (RelationalQueryableMethodTranslatingExpressionVisitor)CreateSubqueryVisitor();
var translation = subqueryVisitor.Visit(expression) as ShapedQueryExpression;
if (translation == null && subqueryVisitor.TranslationErrorDetails != null)
{
AddTranslationErrorDetails(subqueryVisitor.TranslationErrorDetails);
}

return translation;
}

/// <inheritdoc />
protected override QueryableMethodTranslatingExpressionVisitor CreateSubqueryVisitor()
=> new RelationalQueryableMethodTranslatingExpressionVisitor(this);
Expand Down

0 comments on commit 3533470

Please sign in to comment.