Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve synchronization context in SaveChangesAsync for accepting changes #23971

Closed
roji opened this issue Jan 25, 2021 · 1 comment · Fixed by #23988
Closed

Preserve synchronization context in SaveChangesAsync for accepting changes #23971

roji opened this issue Jan 25, 2021 · 1 comment · Fixed by #23988
Assignees
@roji
Labels
area-save-changes closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@roji
Copy link
Member

roji commented Jan 25, 2021

Since #10164, we have ConfigureAwait(false) everywhere; this can cause issues in certain data binding scenarios, when accepting changes triggers a UI change, which is no longer executed on the UI thread (e.g. #22841).

We could specifically use ConfigureAwait(true) in the code path leading to AcceptAllChanges (specifically in two places: DbContext.SaveChangesAsync, StateManager.SaveChangesAsync).
@ajcvickers ajcvickers added this to the 6.0.0 milestone Jan 26, 2021
@roji roji changed the title Consider doing ConfigureAwait(true) in SaveChangesAsync Preserve synchronization context in SaveChangesAsync for accepting changes Jan 26, 2021
@roji roji mentioned this issue Jan 26, 2021
Merged
roji added a commit that referenced this issue Jan 26, 2021
@roji
Preserve synchronization context in SaveChangesAsync
b56b366 
Closes #23971
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 26, 2021
roji added a commit that referenced this issue Jan 26, 2021
@roji
Preserve synchronization context in SaveChangesAsync
761a95c 
Closes #23971
roji added a commit that referenced this issue Jan 26, 2021
@roji
Preserve synchronization context in SaveChangesAsync (#23988)
2de91f6 
Closes #23971
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers mentioned this issue Feb 11, 2021
Merged
@ajcvickers
Copy link
Contributor

Looks like this didn't make it into the preview 1 branch. It was merged after preview 1 branched, but before branding was updated to preview 2.

@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Feb 11, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview2 Mar 5, 2021
@roji roji mentioned this issue Oct 21, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview2, 6.0.0 Nov 8, 2021
@roji roji mentioned this issue Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-save-changes closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Preserve synchronization context in SaveChangesAsync dotnet/efcore
2 participants
@ajcvickers @roji