Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ToFunction overloads that take a MethodInfo #24611

Closed
AndriySvyryd opened this issue Apr 7, 2021 · 1 comment · Fixed by #25437
Closed

Add ToFunction overloads that take a MethodInfo #24611

AndriySvyryd opened this issue Apr 7, 2021 · 1 comment · Fixed by #25437
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Apr 7, 2021 •
edited
Loading

The ToFunction methods on RelationalEntityTypeBuilderExtensions currently take a string. We should add sugar overloads that take a MethodInfo instead and call DbFunction.GetFunctionName on it.
@ajcvickers ajcvickers added this to the 6.0.0 milestone Apr 16, 2021
@ajcvickers ajcvickers added the good first issue This issue should be relatively straightforward to fix. label Apr 16, 2021
@Marusyk
Copy link
Member

Marusyk commented Apr 17, 2021 •
edited
Loading

@AndriySvyryd Could you please add more context?

@AndriySvyryd AndriySvyryd added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed good first issue This issue should be relatively straightforward to fix. labels Aug 3, 2021
@AndriySvyryd AndriySvyryd removed their assignment Aug 3, 2021
AndriySvyryd added a commit that referenced this issue Aug 5, 2021
@AndriySvyryd
Add ToFunction overloads that take a MethodInfo
07949e2 
Add ToView overloads for owned types
Add non-generic ToInMemoryQuery overloads

Fixes #24611
Fixes #21418
Fixes #24600
@AndriySvyryd AndriySvyryd mentioned this issue Aug 5, 2021
Merged
AndriySvyryd added a commit that referenced this issue Aug 6, 2021
@AndriySvyryd
Add ToFunction overloads that take a MethodInfo
8460d0f 
Add ToView overloads for owned types
Add non-generic ToInMemoryQuery overloads

Fixes #24611
Fixes #21418
Fixes #24600
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 12, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc1, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Add ToFunction overloads that take a MethodInfo dotnet/efcore
3 participants
@ajcvickers @AndriySvyryd @Marusyk