Made it possible to use IEnumerable.Empty() in HasDefaultValue. #18240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a test for it. Fix dotnet#17780
|
Please let me know if the bug should be fixed differently. |
src/EFCore.Relational/Extensions/RelationalPropertyExtensions.cs
Outdated
Show resolved
Hide resolved
| .Entity<Customer>() | ||
| .Property(c => c.Orders) | ||
| .HasDefaultValue(Enumerable.Empty<Order>()); | ||
| } |
There was a problem hiding this comment.
Add an assert to check the default value was set
AndriySvyryd
requested changes
Oct 16, 2019
Co-Authored-By: Andriy Svyryd <[email protected]>
|
Closing this for now since there has been no recent activity. To resurrect this for more work, please create a new PR re-based on current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it possible to use IEnumerable.Empty() in HasDefaultValue.
Fixes #17780