Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable/remove flaky tests #23506

Merged
merged 1 commit into from
Nov 27, 2020
+1 −36
Merged

Reenable/remove flaky tests #23506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/EFCore.Relational.Specification.Tests/TransactionTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ public virtual async Task SaveChanges_uses_ambient_transaction(bool async, bool
AssertStoreInitialState();
}

[ConditionalTheory(Skip = "Issue #17017")]
[ConditionalTheory]
[InlineData(true, true)]
[InlineData(true, false)]
[InlineData(false, true)]
Expand Down
35 changes: 0 additions & 35 deletions test/EFCore.SqlServer.FunctionalTests/Query/NorthwindMiscellaneousQuerySqlServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,41 +98,6 @@ CROSS JOIN [Customers] AS [c0]
ORDER BY [t0].[CustomerID]");
}

[ConditionalFact(Skip = "Issue #16006")]
public virtual void Cache_key_contexts_are_detached()
{
var weakRef = Scoper(
() =>
{
var context = new NorthwindRelationalContext(Fixture.CreateOptions());

var wr = new WeakReference(context);

using (context)
{
var orderDetails = context.OrderDetails;

Customer Query(NorthwindContext param)
=> (from c in context.Customers
from o in context.Set<Order>()
from od in orderDetails
from e1 in param.Employees
from e2 in param.Set<Order>()
select c).First();

Assert.NotNull(Query(context));

Assert.True(wr.IsAlive);

return wr;
}
});

GC.Collect();

Assert.False(weakRef.IsAlive);
}

private static T Scoper<T>(Func<T> getter)
{
return getter();
Expand Down