Fix to #23472 - !boolean in query should convert to boolean == false rather than boolean != true where possible #23711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
force-pushed
the
fix23472
branch
2 times, most recently
from
4b4a30a to
f45d186
Compare
smitpatel
approved these changes
Dec 17, 2020
|
Can you also add a test with !boolean alongside here 5b7f684#diff-d9f6f1a40210dca2fe5b3fc6ff8e3f54f9c27f46746915b34505a9327fe43008 So it verifies that it works with value converter also. |
maumar
force-pushed
the
fix23472
branch
3 times, most recently
from
1b624e1 to
1ce7ef4
Compare
…rather than boolean != true where possible When comparing something to bool constant, which is later negated we now flip the constant true -> false and false -> true, rather than flipping the operation from == to !=
ranma42
reviewed
Jun 8, 2024
| { | ||
| return _sqlExpressionFactory.MakeBinary( | ||
| ExpressionType.Equal, | ||
| _sqlExpressionFactory.Constant(!(bool)constant.Value!, constant.TypeMapping), |
There was a problem hiding this comment.
I believe that the value should be negated only if sqlBinaryOperand.OperatorType == ExpressionType.Equal
if sqlBinaryOperand.OperatorType == ExpressionType.NotEqual, the constant should be constructed with constant.Value (no negation) since the operator is already being negated
also, I am quite confident that the NotEqual case is dead code; would it make sense to remove it? (considering that it is wrong and unreachable)
There was a problem hiding this comment.
makes sense - good catch!
ranma42
added a commit
to ranma42/efcore
that referenced
this pull request
Jun 9, 2024
It is implemented incorrectly, namely as if the expression was `NOT(a == b)` and it is currently unused. See dotnet#23711 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing something to bool constant, which is later negated we now flip the constant true -> false and false -> true, rather than flipping the operation from == to !=
Fixes #23472