Add Caching to SqliteDataRecord for Ordinal and Name #24141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Strepto
commented
Feb 12, 2021
bricelam
approved these changes
Mar 12, 2021
This speeds up repeated ordinal and Name access. Example existing usage could be from SqlDataReaderExtension.GetValueOrDefault or similar. Related to dotnet#24140
bricelam
force-pushed
the
SqliteOrdinalCache
branch
from
d2c4747 to
ed2b50d
Compare
|
Thanks! This change should ship in 6.0.0-preview.3 sometime next month. |
|
Nice. Do you have some before and after benchmark speed measurements? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Ordinal and Name Caching to SqliteDataRecord
This speeds up repeated ordinal and Name access, while having probable negligible effect on existing queries to GetName(int) or GetOrdinal(string).
Fixes #24140
This is my first PR, please guide me if there is anything I must do to improve the submission 👍