EFCore: Enable nullable on the project #24265
Conversation
src/EFCore/Internal/InternalDbSet.cs
Outdated
| @@ -173,7 +173,7 @@ public override LocalView<TEntity> Local | |||
| /// any release. You should only use it directly in your code with extreme caution and knowing that | |||
| /// doing so can result in application failures when updating to a new Entity Framework Core release. | |||
| /// </summary> | |||
| public override TEntity Find(params object[] keyValues) | |||
| public override TEntity? Find(params object[]? keyValues) | |||
There was a problem hiding this comment.
Is it useful to allow the user to pass null here when we'll always just return null? Is there some reason to keep this (apart from the brekaing change)?
There was a problem hiding this comment.
Converted to object?[]?
There was a problem hiding this comment.
Leaving it as unresolved if someone else know reason.
There was a problem hiding this comment.
We should throw in the real DbSet if the array is null. (Or, indeed, if any of its values are null.)
There was a problem hiding this comment.
We return null right now. A real DbSet passes off to EntityFinder and it returns null currently rather than throw.
smitpatel
force-pushed
the
smit/MakeShayHappy
branch
from
6f5b829 to
563503a
Compare
src/EFCore.Relational/Metadata/Conventions/SharedTableConvention.cs
Outdated
Show resolved
Hide resolved
smitpatel
force-pushed
the
smit/MakeShayHappy
branch
2 times, most recently
from
dba8ce0 to
3cb3ea7
Compare
Part of #19007 Left nullable enable to make review easier. Can replace all those with regex once we are done with all projects
smitpatel
force-pushed
the
smit/randomness
branch
from
873a4f3 to
28d01a3
Compare
|
Also incorporated feedback from previous PR. |
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Part of #19007
Left nullable enable to make review easier. Can replace all those with regex once we are done with all projects