Using Debug.Fail #24752
Merged
Using Debug.Fail #24752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks OK, but at least for EF Core we've made the decision to not use Debug.Assert (or Fail) since they crash the test process and can make it hard to understand what happened (we use Check.DebugAssert which throws an exception instead). Do we want to do the same in Microsoft.Data.Sqlite? @bricelam @ajcvickers |
|
I'll leave that up to @bricelam. |
bricelam
approved these changes
Apr 26, 2021
|
I'm perfectly fine keeping Debug.Assert/Fail--I use a good test runner that doesn't crash 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.