[6.0] Fix to #24490 - Update exception message when correlated collection cannot be projected #26079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
commented
Sep 16, 2021
| <data name="InsufficientInformationToIdentifyOuterElementOfCollectionJoin" xml:space="preserve"> | ||
| <value>Unable to translate a collection subquery in a projection since the parent query doesn't project the key columns of all tables required to generate results on the client side. This can happen when trying to correlate on keyless entity or when using 'Distinct' or 'GroupBy' operations without projecting all of the key columns.</value> | ||
| <data name="InsufficientInformationToIdentifyElementOfCollectionJoin" xml:space="preserve"> | ||
| <value>Unable to translate a collection subquery in a projection since either parent or the subquery doesn't project necessary information required to uniquely identify it and correctly generate results on the client side. This can happen when trying to correlate on keyless entity type. This can also happen for some cases of projection before 'Distinct' or some shapes of grouping key in case of 'GroupBy'. These should either contain all key properties of the entity that the operation is applied on, or only contain simple property access expressions.</value> |
There was a problem hiding this comment.
I don't think the fwlink is necessary here. The issue should now be pretty niche and after/if we fix #26077 this will only happen for keyless entities, and the exception message length will be substantially reduced. @smitpatel thoughts?
There was a problem hiding this comment.
/cc @roji as our English language expert ;)
ajcvickers
changed the title
bricelam
approved these changes
Sep 21, 2021
…annot be projected Updating the message and resource string name to reflect the changes in behavior after we've improved this scenario. Fixes #24490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the message and resource string name to reflect the changes in behavior after we've improved this scenario.
Fixes #24490