[6.0] Fix SQL Server NTS scaffolding code generation #26160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Sep 23, 2021
ajcvickers
changed the title
This was indeed a change with some far-reaching consequences - I did do my best to proactively add test coverage etc., but clearly some things slipped through. I can look at the change again with fresh eyes to try to flush out more issues, though it may also be more productive if someone else helps with this. |
|
@roji I'm thinking about. Let's discuss in triage tomorrow, assuming you're around. |
|
Let me know if I can help in any way? |
I probably won't be (we can discuss earlier if you want)... But in any case am OK with whatever you decide. |
|
Approved for EFCore 6.0 |
roji
added a commit
to npgsql/efcore.pg
that referenced
this pull request
Dec 22, 2021
roji
added a commit
to npgsql/efcore.pg
that referenced
this pull request
Dec 22, 2021
roji
added a commit
to npgsql/efcore.pg
that referenced
this pull request
Dec 22, 2021
Following dotnet/efcore#26160 (cherry picked from commit 126a6b6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26133
Description
An incorrect type reference prevents scaffolding from working correctly when NetTopologySuite is used.
Customer impact
Customers cannot scaffold databases when using the NetTopologySuite spatial plugin.
How found
Customer
Regression
Yes
Testing
Test for this scenario added in the PR.
Risk
Very low, the fix is trivial and affects scaffolding only (no runtime impact)