Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quirks #26639

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Remove quirks #26639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/EFCore.Cosmos/Query/Internal/CosmosValueConverterCompensatingExpressionVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,6 @@ protected override Expression VisitExtension(Expression extensionExpression)

private Expression VisitShapedQueryExpression(ShapedQueryExpression shapedQueryExpression)
{
if (AppContext.TryGetSwitch("Microsoft.EntityFrameworkCore.Issue26428", out var enabled)
&& enabled)
{
return shapedQueryExpression.Update(
Visit(shapedQueryExpression.QueryExpression), shapedQueryExpression.ShaperExpression);
}

var selectExpression = shapedQueryExpression.QueryExpression;
var updatedSelectExpression = Visit(selectExpression);
return updatedSelectExpression != selectExpression
Expand Down
6 changes: 1 addition & 5 deletions src/EFCore.Design/Scaffolding/Internal/RelationalScaffoldingModelFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,11 +943,7 @@ protected virtual List<string> ExistingIdentifiers(IReadOnlyEntityType entityTyp
}

existingIdentifiers.AddRange(entityType.GetNavigations().Select(p => p.Name));
if (!(AppContext.TryGetSwitch("Microsoft.EntityFrameworkCore.Issue26496", out var enabled)
&& enabled))
{
existingIdentifiers.AddRange(entityType.GetSkipNavigations().Select(p => p.Name));
}
existingIdentifiers.AddRange(entityType.GetSkipNavigations().Select(p => p.Name));
return existingIdentifiers;
}

Expand Down
7 changes: 0 additions & 7 deletions ...EFCore.Relational/Query/Internal/RelationalValueConverterCompensatingExpressionVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,6 @@ protected override Expression VisitExtension(Expression extensionExpression)

private Expression VisitShapedQueryExpression(ShapedQueryExpression shapedQueryExpression)
{
if (AppContext.TryGetSwitch("Microsoft.EntityFrameworkCore.Issue26428", out var enabled)
&& enabled)
{
return shapedQueryExpression.Update(
Visit(shapedQueryExpression.QueryExpression), shapedQueryExpression.ShaperExpression);
}

var selectExpression = shapedQueryExpression.QueryExpression;
var updatedSelectExpression = Visit(selectExpression);
return updatedSelectExpression != selectExpression
Expand Down
6 changes: 0 additions & 6 deletions src/EFCore.Relational/Query/SqlExpressions/SelectExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3301,12 +3301,6 @@ public SelectExpression Update(
Tags = Tags
};

if (AppContext.TryGetSwitch("Microsoft.EntityFrameworkCore.Issue26428", out var enabled)
&& enabled)
{
newSelectExpression._clientProjections = new();
}

// We don't copy identifiers because when we are doing reconstruction so projection is already applied.
// Update method should not be used pre-projection application. There are other methods to change SelectExpression.

Expand Down
7 changes: 2 additions & 5 deletions src/Microsoft.Data.Sqlite.Core/SqliteConnectionFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,8 @@ internal class SqliteConnectionFactory

protected SqliteConnectionFactory()
{
if (!AppContext.TryGetSwitch("Microsoft.Data.Sqlite.Issue26422", out var enabled) || !enabled)
{
AppDomain.CurrentDomain.DomainUnload += (_, _) => ClearPools();
AppDomain.CurrentDomain.ProcessExit += (_, _) => ClearPools();
}
AppDomain.CurrentDomain.DomainUnload += (_, _) => ClearPools();
AppDomain.CurrentDomain.ProcessExit += (_, _) => ClearPools();

_pruneTimer = new Timer(PruneCallback, null, TimeSpan.FromMinutes(4), TimeSpan.FromSeconds(30));
}
Expand Down