Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back support for Cosmos nested dictionaries #34312

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Add back support for Cosmos nested dictionaries #34312

merged 2 commits into from
Aug 2, 2024

Conversation

ajcvickers
Copy link
Contributor

Fixes #34105

This code will be consolidated with the relational UTF8 JSON code when #29825 is implemented. For now, just adding back what was already in Cosmos.

@ajcvickers ajcvickers requested a review from a team July 29, 2024 13:49
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test to CompiledModelCosmosTest

Fixes #34105

This code will be consolidated with the relational UTF8 JSON code when #29825 is implemented. For now, just adding back what was already in Cosmos.
@ajcvickers ajcvickers merged commit d94cc5a into main Aug 2, 2024
7 checks passed
@ajcvickers ajcvickers deleted the MapHack branch August 2, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmos no longer supports Dictionary with TValue type of primitive collection
2 participants