Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0] sync rc1 #194

Merged
merged 1 commit into from
Aug 24, 2022
Merged

[release/7.0] sync rc1 #194

merged 1 commit into from
Aug 24, 2022

Conversation

lewing
Copy link
Member

@lewing lewing commented Aug 24, 2022

commit 5ef6613
Author: Matt Mitchell [email protected]
Date: Wed Aug 24 09:22:40 2022 -0700

Explicitly avoid signing python.cat (#192)

Set the python.cat signature to None so that tooling doesn't complain about not having a signature mapping for this file.

commit 321399a
Author: Matt Mitchell [email protected]
Date: Tue Aug 23 11:51:37 2022 -0700

Do not attempt to sign .cat files (#190)

.cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds.

@lewing
Squashed commit of the following:
0b7f096 
commit 5ef6613
Author: Matt Mitchell <[email protected]>
Date:   Wed Aug 24 09:22:40 2022 -0700

    Explicitly avoid signing python.cat (dotnet#192)

    Set the python.cat signature to None so that tooling doesn't complain about not having a signature mapping for this file.

commit 321399a
Author: Matt Mitchell <[email protected]>
Date:   Tue Aug 23 11:51:37 2022 -0700

    Do not attempt to sign .cat files (dotnet#190)

    .cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds.
@lewing lewing requested a review from akoeplinger August 24, 2022 22:40
@lewing lewing changed the title Squashed commit of the following: [release/7.0] sync rc1 Aug 24, 2022
@lewing lewing requested review from steveisok and radical August 24, 2022 22:41
@lewing lewing merged commit 3e431e9 into dotnet:release/7.0 Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radical radical radical approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@steveisok steveisok Awaiting requested review from steveisok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewing @radical