Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Extensions.ObjectPool has invalid file modified times #2750

Closed
peppy opened this issue Dec 5, 2019 · 16 comments
Closed

Microsoft.Extensions.ObjectPool has invalid file modified times #2750

peppy opened this issue Dec 5, 2019 · 16 comments
Assignees
Milestone

Comments

@peppy
Copy link

peppy commented Dec 5, 2019

The new 3.1 release of Microsoft.Extensions.ObjectPool has incorrect modified dates for its contained (and exposed) dll files. This in turn causes package failure of any project including this package (due to NuGet/Home#7001).

image

image

@peppy peppy changed the title Microsoft.Extensions.ObjectPool package is broken Microsoft.Extensions.ObjectPool has invalid file modified times Dec 5, 2019
@Bert-Proesmans
Copy link

Bert-Proesmans commented Dec 5, 2019

I encountered exactly the same symptoms on
Microsoft.Extensions.Caching.Memory.dll
Microsoft.Extensions.Caching.Memory.xml
Microsoft.Extensions.DependencyInjection.Abstractions.dll
Microsoft.Extensions.DependencyInjection.Abstractions.xml
Microsoft.Extensions.Logging.Abstractions.dll
Microsoft.Extensions.Logging.Abstractions.xml
Microsoft.Extensions.Options.dll
Microsoft.Extensions.Options.xml
Microsoft.Extensions.Primitives.dll
Microsoft.Extensions.Primitives.xml

It also prevents me from running NuGet pack.

@rynowak
Copy link
Member

rynowak commented Dec 5, 2019

@aspnet/build

@rynowak rynowak closed this as completed Dec 5, 2019
@rynowak rynowak reopened this Dec 5, 2019
@rynowak
Copy link
Member

rynowak commented Dec 5, 2019

Sorry, clicked the wrong button.

@jeroenlandheer
Copy link

All Microsoft.Extensions packages are on 1-1-1980. Same problems here, it prevents us from publishing PowerShell packages.

@jeroenlandheer
Copy link

For everyone who's having trouble (probably everyone who's in a timezone above GMT), you can use this PowerShell script to change the date of the files to a value which allows you to pack with Nuget:

Get-ChildItem | Where {$_.LastWriteTime.Year -eq '1980'} | % {$_.LastWriteTime = $_.CreationTime }

@dougbu
Copy link
Member

dougbu commented Dec 5, 2019

@rrelyea I suspect we built 3.1.0 in the window while pack determinism was true i.e. before NuGet/NuGet.Client#3060 was merged and NuGet/Home#8599 was fixed. What exactly do we need to upgrade e.g. the .NET Core SDK in order to get that fix?

@dougbu
Copy link
Member

dougbu commented Dec 5, 2019

/fyi @johnbeisner @mmitche @aspnet/build @leecow @dagood @dleeapho @MichaelSimons @richaverma1 @nguerrera @richlander @SteveCarrollMSFT this is a 3.1.0 content issue.

@wtgodbe
Copy link
Member

wtgodbe commented Dec 5, 2019

We also need to update the SDK to fix the package icon issue - if this will also be caught by that, then that's even more motivation to do so

@rrelyea
Copy link

rrelyea commented Dec 5, 2019

We fixed in final 3.0.100 - so use that or later.

@mmitche
Copy link
Member

mmitche commented Dec 5, 2019

We fixed in final 3.0.100 - so use that or later.

@rrelyea This also fixed in 3.1.100, yes?

@rrelyea
Copy link

rrelyea commented Dec 5, 2019

3.0.100 matches NuGet 5.3 and VS 16.3
3.1.100 matches NuGet 5.4 and VS 16.4
Yes, we fixed on the last day or two of 3.0.100 and did not change behavior after that.
(we have not tried to refix, etc...)

@nkolev92

@Bert-Proesmans
Copy link

Can anyone instruct me what i need to do to make this issue go away? (I know about the powershell one liner as a workaround)

From the response i interpreted that some fix has been applied, but these specific libraries still have a faulty modification date. So far i updated Visual studio (which, i supposed, includes updated nuget binaries), looked for newer versions of the relevant libs to update and removed my local package cache. The end result didn't change, where i expected the modification date to be set correctly again.

@Pilchie
Copy link
Member

Pilchie commented Dec 23, 2019

We haven't published the new versions yet. We will as part of our next servicing update when that is ready.

@analogrelay
Copy link

This should be resolved. Please let us know if you're still seeing this issue!

@ghost ghost locked as resolved and limited conversation to collaborators May 9, 2020
@dougbu
Copy link
Member

dougbu commented Aug 8, 2020

Reopening because Extensions portion of the targeting pack was not previous rebuilt

@dougbu dougbu reopened this Aug 8, 2020
@dougbu dougbu self-assigned this Aug 8, 2020
@dougbu dougbu added this to the 3.1.8 milestone Sep 1, 2020
@dougbu
Copy link
Member

dougbu commented Sep 21, 2020

3.1.8 is now out with this fix included

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants