Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable pack determinism because of unforeseen impact on deployment tools #8599

Closed
nkolev92 opened this issue Sep 17, 2019 · 1 comment · Fixed by NuGet/NuGet.Client#3060
Closed

Disable pack determinism because of unforeseen impact on deployment tools #8599

nkolev92 opened this issue Sep 17, 2019 · 1 comment · Fixed by NuGet/NuGet.Client#3060
Assignees
@nkolev92
Labels
Functionality:Pack Product:dotnet.exe Type:Bug
Milestone
5.3

Comments

@nkolev92
Copy link
Member

nkolev92 commented Sep 17, 2019 •
edited by rrelyea
Loading

NuGet side of dotnet/core#3388.

Figure out the NuGet actions, if any.
Update: looks like we are disabling the "determinisitic pack" behavior in a new build of 3.0.0 and VS 16.3

Insertion bug: https://devdiv.visualstudio.com/DevDiv/_queries/edit/984463

fyi @rrelyea
@nkolev92 nkolev92 added this to the 5.3 milestone Sep 17, 2019
@nkolev92 nkolev92 self-assigned this Sep 17, 2019
@nkolev92 nkolev92 mentioned this issue Sep 17, 2019
Merged
@nkolev92
Copy link
Member Author

Closing for 5.3

@nkolev92 nkolev92 changed the title Pack determinism + impact on deployment tools Disable pack determinism because of unforeseen impact on deployment tools Sep 17, 2019
This was referenced Sep 17, 2019
Open
Closed
Merged
Closed
@nkolev92 nkolev92 mentioned this issue Sep 30, 2019
Closed
@sebastienros sebastienros mentioned this issue Oct 4, 2019
Closed
@dougbu dougbu mentioned this issue Dec 5, 2019
Closed
@dominoFire dominoFire mentioned this issue Apr 8, 2020
Closed
@dougbu dougbu mentioned this issue Jul 22, 2020
Closed
dougbu added a commit to dotnet/extensions that referenced this issue Aug 8, 2020
@dougbu
Update branding to 3.1.8
6038250 
- build targeting pack to pick up NuGet/Home#8599 fix
    - #2750 and dotnet/aspnetcore#24200 1/2
dougbu added a commit to dotnet/extensions that referenced this issue Aug 8, 2020
@dougbu
Update branding to 3.1.8
3cc38af 
- build targeting pack to pick up NuGet/Home#8599 fix
    - #2750 and dotnet/aspnetcore#24200 1/2
@dougbu dougbu mentioned this issue Aug 8, 2020
Merged
@dougbu dougbu mentioned this issue Aug 8, 2020
Merged
ghost pushed a commit to dotnet/extensions that referenced this issue Aug 8, 2020
@dotnet-maestro-bot @wtgodbe @dougbu
[automated] Merge branch 'release/3.1' => 'master' (#3392)
0a2a483 
* Update branding to 2.1.21 (#3353)

* Fixup

* Update branding to 3.1.8
- build targeting pack to pick up NuGet/Home#8599 fix
    - #2750 and dotnet/aspnetcore#24200 1/2

* Revert "Update branding to 3.1.8"
- oops

This reverts commit 6038250.

Co-authored-by: John Luo <[email protected]>
Co-authored-by: Will Godbe <[email protected]>
Co-authored-by: Doug Bunting <[email protected]>
dougbu added a commit to dotnet/extensions that referenced this issue Aug 8, 2020
@dougbu
Update branding to 3.1.8
30bf387 
- build targeting pack to pick up NuGet/Home#8599 fix
    - #2750 and dotnet/aspnetcore#24200 1/2
    - suppress MSB3243 warnings because ref/ and src/ assemblies have different versions
dougbu added a commit to dotnet/extensions that referenced this issue Aug 8, 2020
@dougbu
Update branding to 3.1.8
7487ce9 
- build targeting pack to pick up NuGet/Home#8599 fix
    - #2750 and dotnet/aspnetcore#24200 1/2
    - suppress MSB3243 warnings because ref/ and src/ assemblies have different versions
- fake the baseline update
    - remainder must be done after the 3.1.7 release
dougbu added a commit to dotnet/extensions that referenced this issue Aug 8, 2020
@dougbu
Update branding to 3.1.8
e2f0c92 
- build targeting pack to pick up NuGet/Home#8599 fix
    - #2750 and dotnet/aspnetcore#24200 1/2
    - suppress MSB3243 warnings because ref/ and src/ assemblies have different versions
- fake the baseline update
    - remainder must be done after the 3.1.7 release
dougbu added a commit to dotnet/aspnetcore that referenced this issue Aug 9, 2020
@dougbu
Update branding to 3.1.8
34f8f3c 
- build targeting pack to pick up NuGet/Home#8599 fix
    - dotnet/extensions#2750 and #24200 2/2
    - requires follow-up after next official extensions build
- fake the baseline update
    - remainder must be done after the 3.1.7 release
dougbu added a commit to dotnet/extensions that referenced this issue Aug 11, 2020
@dougbu
Update branding to 3.1.8
6087bc7 
- build targeting pack to pick up NuGet/Home#8599 fix
    - #2750 and dotnet/aspnetcore#24200 1/2
    - suppress MSB3243 warnings because ref/ and src/ assemblies have different versions
- fake the baseline update
    - remainder must be done after the 3.1.7 release
dougbu added a commit to dotnet/aspnetcore that referenced this issue Aug 11, 2020
@dougbu
Update branding to 3.1.8
9f03b0a 
- build targeting pack to pick up NuGet/Home#8599 fix
    - dotnet/extensions#2750 and #24200 2/2
    - requires follow-up after next official extensions build
- fake the baseline update
    - remainder must be done after the 3.1.7 release
@tommysor tommysor mentioned this issue Nov 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Functionality:Pack Product:dotnet.exe Type:Bug
Projects
None yet
Milestone
5.3
Development

Successfully merging a pull request may close this issue.

Disable pack determinism because of unforeseen impact on deployment tools NuGet/NuGet.Client
1 participant
@nkolev92