Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify LoggingOptions BodyReadTimeout #4634

Closed
eerhardt opened this issue Oct 30, 2023 · 0 comments
Closed

Clarify LoggingOptions BodyReadTimeout #4634

eerhardt opened this issue Oct 30, 2023 · 0 comments

Comments

@eerhardt
Copy link
Member

/// The value should be in the range of 1 millisecond to 1 minute.
/// </remarks>
[TimeSpan(Millisecond, Hour)]
public TimeSpan BodyReadTimeout { get; set; } = TimeSpan.FromSeconds(1);

The comment here says it should be capped at 1 minute, but the code says it is capped at 1 hour. We should figure out which is appropriate (probably 1 minute) and correct the code.

geeknoid pushed a commit that referenced this issue Oct 30, 2023
geeknoid added a commit that referenced this issue Oct 30, 2023
Co-authored-by: Martin Taillefer <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants