-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling logging enrichment effects the logged message #4795
Labels
Comments
jamiewinder
added
bug
This issue describes a behavior which is not expected - a bug.
untriaged
labels
Dec 6, 2023
Oh, that shouldn't be. Thanks for the report. |
geeknoid
pushed a commit
that referenced
this issue
Dec 7, 2023
geeknoid
pushed a commit
that referenced
this issue
Dec 8, 2023
ghost
added
the
work in progress 🚧
label
Dec 8, 2023
geeknoid
added a commit
that referenced
this issue
Dec 11, 2023
…uments. (#4798) * Fix #4795 And while I was in the neighborhood, also addresses #4637 --------- Co-authored-by: Martin Taillefer <[email protected]> Co-authored-by: Igor Velikorossov <[email protected]>
ghost
removed
the
work in progress 🚧
label
Dec 11, 2023
sebastienros
added a commit
that referenced
this issue
Dec 18, 2023
* Address issue with legacy logger's calling ToString on the TState arguments. (#4798) * Fix #4795 And while I was in the neighborhood, also addresses #4637 --------- Co-authored-by: Martin Taillefer <[email protected]> Co-authored-by: Igor Velikorossov <[email protected]> * Add missing [GeneratedCode] attribute (#4802) The logging code generator emits a static lambda. The lambda's containing function is annotated with the [GeneratedCode] attribute, but the lambda itself is not. The result is that code generators can get confused, considering the lambda as being user code. This PR adds the [GeneratedCode] attribute to the lambda. Co-authored-by: Martin Taillefer <[email protected]> * Add more information and sample to Http.Diagnostics Readme (#4808) * Add more information and sample to Http.Diagnostics Readme * Simplify first statement and adding using statements. * Also add extra docs to xml docs * Improve code coverage for M.E.Diagnostics.Testing (#4820) --------- Co-authored-by: Martin Taillefer <[email protected]> Co-authored-by: Martin Taillefer <[email protected]> Co-authored-by: Igor Velikorossov <[email protected]> Co-authored-by: Jose Perez Rodriguez <[email protected]> Co-authored-by: Sébastien Ros <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Description
Using
EnableEnrichment
onILoggingBuilder
causes the Message of the log events to be some type name.Reproduction Steps
Example:
This outputs
If you disable / comment out the EnableEnrichment line:
Note the State.Message property value.
Expected behavior
The State.Message property should be unaffected.
Actual behavior
The State.Message property is the string "Microsoft.Extensions.Logging.ExtendedLogger\u002BLegacyTagJoiner"
Regression?
No response
Known Workarounds
No response
Configuration
No response
Other information
No response
The text was updated successfully, but these errors were encountered: