Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove signing.props #3989

Merged
merged 1 commit into from
May 23, 2023
Merged

Remove signing.props #3989

merged 1 commit into from
May 23, 2023

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented May 23, 2023 •
edited by ghost
Loading

This is not needed, as the defaults are fine for this repo.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned mmitche May 23, 2023
joperezr
joperezr approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @mmitche! This has been validated in a pipeline already. FYI @RussKie

@joperezr joperezr enabled auto-merge (squash) May 23, 2023 17:43
@joperezr joperezr merged commit e65eb83 into dotnet:main May 23, 2023
geeknoid pushed a commit that referenced this pull request May 23, 2023
@mmitche
Attempt sign (#3989)
b689484
@RussKie RussKie added this to the 8.0 Preview5 milestone Jun 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

Assignees

@mmitche mmitche

Labels
None yet
Projects
None yet
Milestone
8.0 Preview5
Development

Successfully merging this pull request may close these issues.
3 participants
@mmitche @joperezr @RussKie