Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke SocketHandling since it's now in dotnet/runtime #4221

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

geeknoid
Copy link
Member

@geeknoid geeknoid commented Jul 27, 2023

dotnet/runtime#84075

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned geeknoid Jul 27, 2023
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. What about the API that wasn't moved down? Don't we still wanted a thin layer for the certificate handling in here?

@geeknoid geeknoid merged commit 45356df into main Jul 27, 2023
@geeknoid geeknoid deleted the geeknoid/sockethandling branch July 27, 2023 19:47
@ghost ghost added this to the 8.0 RC1 milestone Jul 27, 2023
@geeknoid
Copy link
Member Author

@joperezr Yes, we probably do want this layer. But that work can be handled separately when we get there. At this point, we have nothing in this repo needing this functionality, so we can defer for now.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants