Fix issue in metering generator when cyclic references causes VS to crash #4231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
xakep139
approved these changes
Aug 1, 2023
dariusclay
commented
Aug 1, 2023
There was a problem hiding this comment.
We could extract Microsoft.Gen.Logging/Parsing/TransitiveTypeCycleException into a shared area and reuse it here.
dariusclay
commented
Aug 1, 2023
| @@ -147,7 +147,7 @@ This sets up necessary environmental variables and opens the repository in VS Co | |||
| * The file format is an MSBuild Binary Log. Install the [MSBuild Structured Log Viewer][msbuild-log-viewer] to view them. | |||
| * Windows Forms uses Visual Studio MSBuild but for certain features we require the latest MSBuild from .NET Core/.NET SDK. If you are on an official version of [Visual Studio][VS-download] (i.e. not a Preview version), then you may need to enable previews for .NET Core/.NET SDKs in VS. | |||
| * you can do this in VS under Tools->Options->Environment->Preview Features->Use previews of the .Net Core SDK (Requires restart) | |||
|
|
|||
| * When restoring packages, if you get the following message: "The SSL connection could not be established, see inner exception. Unable to read data from the transport connection", try disabling IPv6 on your network adapter. | |||
There was a problem hiding this comment.
This is dealing with an issue I had when getting the project to build locally. I spent more time than I wanted to on it.
geeknoid
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a strong typed metering class contains cyclic type references it will lead to a stack overflow.
Fixes #4228
This change detects any cycles and emits
R9G071: A metric class has cycles in its type hierarchyMicrosoft Reviewers: Open in CodeFlow