Remove naming constraints in auto-client. #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarbosapn
suggested changes
Aug 2, 2023
ghost
added
the
waiting-author-feedback 📭
- The auto-client generator no longer disallows method names and parameter names that start with _. This was previously done to avoid naming conflicts with identifiers created by the generator. Now, the generator dynamically picks new names if there are conflicts with user-defined symbols.
geeknoid
force-pushed
the
geeknoid/autoclient
branch
from
8f82aaf to
94f1183
Compare
ghost
removed
the
waiting-author-feedback 📭
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow