Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a bunch of symbols #4239

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Rename a bunch of symbols #4239

merged 1 commit into from
Aug 3, 2023

Conversation

geeknoid
Copy link
Member

@geeknoid geeknoid commented Aug 3, 2023

  • "Properties" and "Dimensions" in the telemetry space are now just "tags" like in the APIs in dotnet/runtime.

There's a lot of changed files here, but hopefully no functional changes at all. Just renames.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned geeknoid Aug 3, 2023
@geeknoid geeknoid changed the title Rename a bunch of SymbolLoaderTests Rename a bunch of symbols Aug 3, 2023
- "Properties" and "Dimensions" in the telemetry space are now just
"tags" like in the APIs in dotnet/runtime.

There's a lot of changed files here, but hopefully no functional changes at
all. Just renames.
@geeknoid
Copy link
Member Author

geeknoid commented Aug 3, 2023

Since this is just a bunch of mind-numbing renames, I'm going to force this in.

@geeknoid geeknoid merged commit 33e95f7 into main Aug 3, 2023
@geeknoid geeknoid deleted the geeknoid/tags branch August 3, 2023 21:43
@ghost ghost added this to the 8.0 RC1 milestone Aug 3, 2023
@xakep139
Copy link
Contributor

xakep139 commented Aug 8, 2023

This also fixes #4209

@xakep139 xakep139 linked an issue Aug 8, 2023 that may be closed by this pull request
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ILogPropertyCollector to ILogTagCollector
2 participants