[main] Update dependencies from dotnet/aspnetcore #4262
Merged
+133
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
|
Interesting so looks like the Http Resilience tests are failing with this update with the following callstack: @noahfalk @MihaZupan @antonfirsov @tarekgh Was this method removed recently? Does this ring any bells? FYI @martintmk since the failing tests are in http resilience. |
|
mmm that is very weird actually, I do see the method is still there: |
|
Don't think we changed anything around this property since it was introduced, it definitely wasn't removed. cc: @CarnaViire in case it's related to the client factory |
|
mm seems like it is just a mismatch from the runtime we use. I'm trying to update the SDK used by the repo and I believe that should fix this issue. |
|
Yup, looks like the issue was with the SDK as bumping it fixed the tests for me at least locally. Pushing the change to see if this passes CI now. Sorry for the randomization folks. |
In general, we should be at least at the same version as dotnet/aspnetcore. |
|
|
…0230809.22 Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rc.1.23409.1 -> To Version 8.0.0-rc.1.23409.22 Dependency coherency updates Microsoft.Bcl.TimeProvider,Microsoft.Extensions.Caching.Abstractions,Microsoft.Extensions.Caching.Memory,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Binder,Microsoft.Extensions.Configuration.CommandLine,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.Configuration,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.Hosting,Microsoft.Extensions.Http,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging.Configuration,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging,Microsoft.Extensions.Options.ConfigurationExtensions,Microsoft.Extensions.Options.DataAnnotations,Microsoft.Extensions.Options,Microsoft.Extensions.Primitives,System.Collections.Immutable,System.Configuration.ConfigurationManager,System.Diagnostics.DiagnosticSource,System.Diagnostics.PerformanceCounter,System.IO.Hashing,System.Net.Http.Json,System.Security.Cryptography.Pkcs,System.Security.Cryptography.Xml,System.Text.Encodings.Web,System.Text.Json,System.Runtime.Caching From Version 8.0.0-rc.1.23404.1 -> To Version 8.0.0-rc.1.23408.18 (parent: Microsoft.AspNetCore.App.Runtime.win-x64
RussKie
force-pushed
the
darc-main-30268223-4571-4989-a0a2-3857af056c1c
branch
from
439d52c to
c5c4bea
Compare
dotnet-maestro
bot
deleted the
darc-main-30268223-4571-4989-a0a2-3857af056c1c
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/aspnetcore
Microsoft Reviewers: Open in CodeFlow