Remove unnecessary TcpListener initialization #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknoid
approved these changes
Aug 20, 2023
andrey-noskov
approved these changes
Aug 21, 2023
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/extensions/actions/runs/5930463907 |
|
/backport to release/8.0-rc1 |
|
Started backporting to release/8.0-rc1: https://github.com/dotnet/extensions/actions/runs/5930470373 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem right to both start the
TcpListenerwhen we don't yet know that the system is healthy, and it's not using any connections limits. When theUpdateHealthStatusAsyncmethod is called then it might not got call Start again, and even when it's called then the listener is active and the max pending connections value is not taken into account.I was not able to create a unit test that would make it in a state where that it rejects connections since it's opening them in a fast paced while loop.
Microsoft Reviewers: Open in CodeFlow