Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Contextual Options readme #4650

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Expand Contextual Options readme #4650

merged 2 commits into from
Nov 1, 2023

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Nov 1, 2023 •
edited by ghost
Loading

I pulled this example from the acceptance tests.

Microsoft Reviewers: Open in CodeFlow

@Tratcher Tratcher added this to the 8.0-rtm milestone Nov 1, 2023
@Tratcher Tratcher self-assigned this Nov 1, 2023
joperezr
joperezr approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@joperezr joperezr enabled auto-merge (squash) November 1, 2023 23:21
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.ResourceMonitoring 98 100
Microsoft.Extensions.Telemetry 92 93
Microsoft.AspNetCore.Diagnostics.Middleware 99 100

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=458025&view=codecoverage-tab

@joperezr joperezr merged commit ebafbeb into dotnet:release/8.0 Nov 1, 2023
6 checks passed
@Tratcher Tratcher deleted the tratcher/readmes/context branch November 3, 2023 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

@sebastienros sebastienros Awaiting requested review from sebastienros

@RussKie RussKie Awaiting requested review from RussKie

@geeknoid geeknoid Awaiting requested review from geeknoid

Assignees

@Tratcher Tratcher

Labels
None yet
Projects
None yet
Milestone
8.0-rtm
Development

Successfully merging this pull request may close these issues.
3 participants
@Tratcher @dotnet-comment-bot @joperezr