Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncState
uses holder objectAsyncStateHolder
that usesList<object?>
collection. Write operations to that collection are not thread safe includingEnsureCapacity()
method. If the async flow is shared between multiple threads theList<>
andAsyncState
is modified in parallel the list might lose some data.The fix replaces List<object?> with custom
Features
class that encapsulates List<object?> collection and synchronizes when its size needs to be expanded.Microsoft Reviewers: Open in CodeFlow