Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable back potentially flaky test #5308

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Enable back potentially flaky test #5308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ...braries/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Tests/Linux/AcceptanceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public void Adding_Linux_Resource_Utilization_With_Section_Registers_SnapshotPro
Assert.Equal(100_000UL, provider.Resources.MaximumMemoryInBytes);
}

[ConditionalFact(Skip = "Flaky test, see https://github.com/dotnet/extensions/issues/3997")]
[ConditionalFact]
[OSSkipCondition(OperatingSystems.Windows | OperatingSystems.MacOSX, SkipReason = "Linux specific tests")]
public Task ResourceUtilizationTracker_Reports_The_Same_Values_As_One_Can_Observe_From_Gauges()
{
Expand All @@ -202,6 +202,7 @@ public Task ResourceUtilizationTracker_Reports_The_Same_Values_As_One_Can_Observ
{ new FileInfo("/sys/fs/cgroup/cpuset/cpuset.cpus"), "0-19"},
{ new FileInfo("/sys/fs/cgroup/cpu/cpu.cfs_quota_us"), "12"},
{ new FileInfo("/sys/fs/cgroup/cpu/cpu.cfs_period_us"), "6"},
{ new FileInfo("/sys/fs/cgroup/cpu/cpu.shares"), "1024"},
{ new FileInfo("/sys/fs/cgroup/memory/memory.stat"), "total_inactive_file 100"},
});

Expand Down Expand Up @@ -260,10 +261,12 @@ public Task ResourceUtilizationTracker_Reports_The_Same_Values_As_One_Can_Observ

var utilization = tracker.GetUtilization(TimeSpan.FromSeconds(5));

Assert.Equal(double.NaN, utilization.CpuUsedPercentage);
Assert.Equal(0, utilization.CpuUsedPercentage);
Assert.Equal(100, utilization.MemoryUsedPercentage);
Assert.Equal(utilization.CpuUsedPercentage, cpuFromGauge);
Assert.Equal(utilization.MemoryUsedPercentage, memoryFromGauge);
Assert.True(double.IsNaN(cpuFromGauge));

// gauge multiplied by 100 because gauges are in range [0, 1], and utilization is in range [0, 100]
Assert.Equal(utilization.MemoryUsedPercentage, memoryFromGauge * 100);

fileSystem.ReplaceFileContent(new FileInfo("/sys/fs/cgroup/memory/memory.usage_in_bytes"), "50100");
fileSystem.ReplaceFileContent(new FileInfo("/proc/stat"), "cpu 11 10 10 10 10 10 10 10 10 10");
Expand All @@ -277,9 +280,9 @@ public Task ResourceUtilizationTracker_Reports_The_Same_Values_As_One_Can_Observ
utilization = tracker.GetUtilization(TimeSpan.FromSeconds(5));

Assert.Equal(1, utilization.CpuUsedPercentage);
Assert.Equal(utilization.CpuUsedPercentage, cpuFromGauge);
Assert.Equal(utilization.CpuUsedPercentage, cpuFromGauge * 100);
Assert.Equal(50, utilization.MemoryUsedPercentage);
Assert.Equal(utilization.MemoryUsedPercentage, memoryFromGauge);
Assert.Equal(utilization.MemoryUsedPercentage, memoryFromGauge * 100);

return Task.CompletedTask;
}
Expand Down