Use ToChatCompletion / ToStreamingChatCompletionUpdates in CachingChatClient #5616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tClient Adds a ToStreamingChatCompletionUpdates method that's the counterpart to the recently added ToChatCompletion. Then uses both from CachingChatClient instead of its now bespoke coalescing implementation. When coalescing is enabled (the default), CachingChatClient caches everything as a ChatCompletion, rather than distinguishing streaming and non-streaming.
src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatCompletion.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Nov 11, 2024
stephentoub
added a commit
to stephentoub/extensions
that referenced
this pull request
Nov 19, 2024
…tClient (dotnet#5616) * Use ToChatCompletion / ToStreamingChatCompletionUpdates in CachingChatClient Adds a ToStreamingChatCompletionUpdates method that's the counterpart to the recently added ToChatCompletion. Then uses both from CachingChatClient instead of its now bespoke coalescing implementation. When coalescing is enabled (the default), CachingChatClient caches everything as a ChatCompletion, rather than distinguishing streaming and non-streaming. * Address PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a ToStreamingChatCompletionUpdates method that's the counterpart to the recently added ToChatCompletion.
Then uses both from CachingChatClient instead of its now bespoke coalescing implementation. When coalescing is enabled (the default), CachingChatClient caches everything as a ChatCompletion, rather than distinguishing streaming and non-streaming.
Microsoft Reviewers: Open in CodeFlow