Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling LanguageFeature.EnforceAttributeTargets from F# 9.0 #17514

Closed
KevinRansom opened this issue Aug 8, 2024 · 2 comments
Closed

Disabling LanguageFeature.EnforceAttributeTargets from F# 9.0 #17514

KevinRansom opened this issue Aug 8, 2024 · 2 comments

Comments

@KevinRansom
Copy link
Member

This feature mysteriously causes getAllSymbols to duplicate the report some symbols until we understand why this happens and is it correct, I am reverting EnforceAttributeTargets from F# 9.0 back to preview

Repo:
With EnforceTargetAttributes set to F# 9.0, in VS using test explorer run the test case observe the failure.

image

@vzarytovskii
Copy link
Member

FYI @edgarfgp, we will look into it once done with adjusting tests and baselines for 9

@edgarfgp
Copy link
Contributor

edgarfgp commented Aug 8, 2024

FYI @edgarfgp, we will look into it once done with adjusting tests and baselines for 9

Not problem. The duplication of symbols most likely is due to "how in some cases the type check is duplicated" producing 2-3 times the same errors/warning and in this case symbols.

Let me know if there is anything I can do to help.

@KevinRansom KevinRansom modified the milestones: Backlog, August-2024 Aug 13, 2024
KevinRansom added a commit to KevinRansom/fsharp that referenced this issue Aug 18, 2024
KevinRansom added a commit to KevinRansom/fsharp that referenced this issue Aug 21, 2024
psfinaki pushed a commit that referenced this issue Aug 22, 2024
* Fix 17514: #17514

* LoaderOptimization thingy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants