Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define ParsedHashDirective arguments as ParsedHashDirectiveArgument instead of strings. #11733

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Define ParsedHashDirective arguments as ParsedHashDirectiveArgument instead of strings. #11733

merged 1 commit into from
Jun 28, 2021

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jun 26, 2021

Fixes #11732

@vzarytovskii vzarytovskii merged commit 52130f8 into dotnet:main Jun 28, 2021
@nojaf nojaf deleted the fix-hashDirectiveArg branch June 28, 2021 14:08
@nojaf
Copy link
Contributor Author

nojaf commented Jun 29, 2021

Thanks for the merge @vzarytovskii!
Any idea if this produced a new nightly package?
The last version I seem to find is 40.0.1-preview.21323.6 published on June 24.

@vzarytovskii
Copy link
Member

Thanks for the merge @vzarytovskii!
Any idea if this produced a new nightly package?
The last version I seem to find is 40.0.1-preview.21323.6 published on June 24.

I don't think we publish nighlies automatically, correct me if I'm wrong @KevinRansom.

@nojaf nojaf mentioned this pull request Jul 14, 2021
Closed
5 tasks
@nojaf nojaf mentioned this pull request Oct 28, 2021
Closed
@smoothdeveloper smoothdeveloper mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SourceIdentifier cannot be used as hashDirectiveArg anymore
2 participants
@nojaf @vzarytovskii